feat: klip-14 - rowtime as pseduocolumn #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#3734 implements [KLIP 14 - ROWTIME as Pseudocolumn](https://github.com/confluentinc/ksql/blob/master/design-proposals/klip-14-rowtime-as-pseudocolumn.md) BREAKING CHANGE: Select star, i.e. `select *`, no longer expands to include `ROWTIME` column(s). Instead, `ROWTIME` is only included in the results of queries if explicitly included in the projection, e.g. `select rowtime, *`. This only affects new statements. Any view previously created via a `CREATE STREAM AS SELECT` or `CREATE TABLE AS SELECT` statement is unaffected.
big-andy-coates
commented
Apr 23, 2020
| @@ -30,7 +30,8 @@ | |||
| public class FieldInfo { | |||
|
|
|||
| public enum FieldType { | |||
| SYSTEM, KEY | |||
| SYSTEM, // To be removed in the future. 0.9 saw this value no longer used. | |||
There was a problem hiding this comment.
Kept SYSTEM around for now, so that using a later CLI with old server doesn't result in a deserialization error.
Not strictly necessary, but simple to do.
big-andy-coates
commented
Apr 23, 2020
| @@ -39,6 +40,7 @@ private EntityUtil() { | |||
|
|
|||
| public static List<FieldInfo> buildSourceSchemaEntity(final LogicalSchema schema) { | |||
| final List<FieldInfo> allFields = schema.columns().stream() | |||
| .filter(f -> f.namespace() != Namespace.META) | |||
There was a problem hiding this comment.
This filters ROWTIME from the schema returned by DESCRIBE etc.
big-andy-coates
commented
Apr 23, 2020
| @@ -55,7 +55,6 @@ public static LogicalSchema buildSchema( | |||
| } | |||
|
|
|||
| return builder | |||
| .valueColumns(schema.metadata()) | |||
There was a problem hiding this comment.
These changes remove ROWTIME from pull queries that use select *.
big-andy-coates
commented
Apr 23, 2020
Comment on lines
+150
to
+161
| final Stream<Column> keys = columns.stream() | ||
| .filter(c -> schema.isKeyColumn(c.name())); | ||
|
|
||
| final List<Column> all = partitioned.get(true); | ||
| all.addAll(partitioned.get(false)); | ||
| return all.stream().map(Column::name); | ||
| final Stream<Column> windowBounds = columns.stream() | ||
| .filter(c -> SchemaUtil.isWindowBound(c.name())); | ||
|
|
||
| final Stream<Column> values = columns.stream() | ||
| .filter(c -> !SchemaUtil.isWindowBound(c.name())) | ||
| .filter(c -> !schema.isKeyColumn(c.name())) | ||
| .filter(c -> !schema.isMetaColumn(c.name())); | ||
|
|
||
| return Streams.concat(keys, windowBounds, values).map(Column::name); |
There was a problem hiding this comment.
This change excludes ROWTIME from push / persistent queries that use * in the projection.
Conflicting files ksqldb-rest-app/src/test/java/io/confluent/ksql/rest/server/resources/streaming/WebSocketSubscriberTest.java
Conflicting files ksqldb-engine/src/test/java/io/confluent/ksql/planner/plan/DataSourceNodeTest.java
JimGalasyn
approved these changes
Apr 23, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #3734
implements KLIP 14 - ROWTIME as Pseudocolumn
BREAKING CHANGE:
Select star, i.e.
select *, no longer expands to includeROWTIMEcolumn(s). Instead,ROWTIMEis only included in the results of queries if explicitly included in the projection, e.g.select rowtime, *.This only affects new statements. Any view previously created via a
CREATE STREAM AS SELECTorCREATE TABLE AS SELECTstatement is unaffected.Reviewing notes:
PR broken down into separate commits:
Testing done
usual.
Reviewer checklist