fix: fix NPE in latest_by_offset if first element being processed has null… #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
approved these changes
Apr 2, 2020
added 2 commits
April 3, 2020 17:21
spena
pushed a commit
to spena/ksql
that referenced
this pull request
May 14, 2020
spena
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a NPE which occurs in the latest_by_offset UDAF when the first time a value is seen it is null, then it is null again.
We already had a test for null values but it did not exercise this specific case.
Testing done
Added new QTT test
Reviewer checklist