Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Catch server startup exceptions #4974

Merged
merged 5 commits into from
Apr 15, 2020
Merged

fix: Catch server startup exceptions #4974

merged 5 commits into from
Apr 15, 2020

Conversation

purplefox
Copy link
Contributor

@purplefox purplefox commented Apr 2, 2020 •
edited by apurvam
Loading

Description

fixes #4873

This is a stacked PR, please just review the top commit(s).

This PR fixes a couple of issues that make it hard to diagnose ksqlDB server startup issues.

  1. Exceptions thrown from startup currently aren't logged, making it hard to diagnose startup issues
  2. NPE thrown from StreamQueryResource.closeMetrics

Testing done

N/A

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner April 2, 2020 06:47
stevenpyzhang
stevenpyzhang approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@stevenpyzhang stevenpyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the startup fix. @vpapavas has this pr for the pull query metrics npe #4972

vcrfxia
vcrfxia approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@purplefox purplefox force-pushed the catch_server_startup_exceptions branch 2 times, most recently from 4bae1cc to 0f34267 Compare April 8, 2020 13:51
@stevenpyzhang stevenpyzhang mentioned this pull request Apr 8, 2020
Closed
@purplefox purplefox force-pushed the catch_server_startup_exceptions branch from 0f34267 to e7b2553 Compare April 15, 2020 07:39
@purplefox purplefox merged commit 898f3a1 into confluentinc:master Apr 15, 2020
@purplefox purplefox deleted the catch_server_startup_exceptions branch April 28, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

@stevenpyzhang stevenpyzhang stevenpyzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message when starting two KSQL servers with same address
3 participants
@purplefox @vcrfxia @stevenpyzhang