fix: don't display decimals in scientific notation in CLI #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4722 This change sees decimals being returned by the rest api avoiding use of scientific notation. For example, a decimal such as `100` will be returned as `100` and not `1e+2`. The CLI just displays what it given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4722
This change sees decimals being returned by the rest api avoiding use of scientific notation. For example, a decimal such as
100will be returned as100and not1e+2.The CLI just displays what it given.
Note: this does not affect how data in persistent queries is written. I believe the json serializer will still prefer scientific notation.
NOTE: This is targeted at 5.4.x at the moment. It's a minor change that can be included in the new point release for 5.4 and in 5.5.
Testing done
added unit test.
Reviewer checklist