fix: stop logging about command topic creation on startup if exists (MINOR) #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4708 * Changed the code to only log about `Creating topic _confluent-ksql-4_command_topic with replication factor of 1 which is less than 2` if its actually creating to the command topic, otherwise log different message, (UX improvement) * Fixed the code to not log `Corrected retention.ms on ksql internal topic. topic:_confluent-ksql-4_command_topic, retention.ms:9223372036854775807` when retention already correctly set, (bug fix). The bug on the retention logging was that the code that checks to see if a change needs applying was comparing `Long.MAX_VALUE` with a String holding the same value. Changed code to compare like for like.
|
Merging without review as its been 4 days... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4708
Creating topic _confluent-ksql-4_command_topic with replication factor of 1 which is less than 2if its actually creating to the command topic, otherwise log different message, (UX improvement)Corrected retention.ms on ksql internal topic. topic:_confluent-ksql-4_command_topic, retention.ms:9223372036854775807when retention already correctly set, (bug fix).The bug on the retention logging was that the code that checks to see if a change needs applying was comparing
Long.MAX_VALUEwith a String holding the same value. Changed code to compare like for like.Testing done
unit tests updated.
Reviewer checklist