feat: remove WindowStart() and WindowEnd() UDAFs #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two UDAFs were introduced to allow access to the start and end times of the window in a windowed source. `WINDOWSTART` and `WINDOWEND` are now accessible as columns to be used in the SELECT of a query, (outside of UDAFs). This makes the two UDAFs redundant. BREAKING CHANGE: The `WindowStart()` and `WindowEnd()` UDAFs have been removed from KSQL. Use the `WindowStart` and `WindowEnd` system columns to access the window bounds within the SELECT expression instead.
JimGalasyn
approved these changes
Feb 6, 2020
2 tasks
agavra
approved these changes
Feb 6, 2020
ksql-engine/src/main/java/io/confluent/ksql/planner/plan/AggregateNode.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These two UDAFs were introduced to allow access to the start and end times of the window in a windowed source.
WINDOWSTARTandWINDOWENDare now accessible as columns to be used in the SELECT of a query, (outside of UDAFs). This makes the two UDAFs redundant.BREAKING CHANGE: The
WindowStart()andWindowEnd()UDAFs have been removed from KSQL. Use theWindowStartandWindowEndsystem columns to access the window bounds within the SELECT expression instead.Testing done
Usual.
Reviewer checklist