Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address upstream change in KafkaAvroDeserializer (revert previous fix) #3437

Conversation

stevenpyzhang
Copy link
Member

Description

#3372 was merged in order to unblock our build due to an upstream change in SR confluentinc/schema-registry@c4b4879

That SR change has been reverted in confluentinc/schema-registry@ca4f640
so we need to undo the previous fix in order for the build to work.

Testing done

mvn clean install

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang requested a review from a team as a code owner September 27, 2019 20:04
Copy link
Member

@vpapavas vpapavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@vpapavas vpapavas requested a review from a team September 27, 2019 20:11
@stevenpyzhang stevenpyzhang merged commit bed164b into confluentinc:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants