feat: move filters to plan builder #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Sep 16, 2019
This patch moves SqlPredicate to ksql-execution and moves the code that filters kstreams into execution step builders. There is also a change to pull out rewriting rowtime filters from SqlPredicate into schemakstream, since the plan should just have the rewritten filters.
e91dcc3 to
acf7cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch moves SqlPredicate to ksql-execution and moves the
code that filters kstreams into execution step builders. There
is also a change to pull out rewriting rowtime filters from
SqlPredicate into schemakstream, since the plan should just
have the rewritten filters.
Testing done
Reviewer checklist