Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DESCRIBE functionality for connectors #3206

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Aug 13, 2019

Description

Implements functionality to describe a connector.

Testing done

Unit testing and local test:

ksql> DESCRIBE CONNECTOR "jdbc-connector2";

Name                 : jdbc-connector2
Type                 : io.confluent.connect.jdbc.JdbcSourceConnector
State                : RUNNING
WorkerId             : 10.200.7.69:8083

 Task ID | State   | Error Trace
---------------------------------
 0       | RUNNING |
---------------------------------

 Source Name           | Kafka Topic | Type
---------------------------------------------
 JDBC_CONNECTOR2_USERS | jdbc2-users | TABLE
---------------------------------------------

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner August 13, 2019 18:57
@agavra agavra force-pushed the connect_describe branch 2 times, most recently from 0d92e93 to e182ca0 Compare August 14, 2019 19:44
Copy link
Contributor

@cpettitt-confluent cpettitt-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions and a few suggestions.

setupConfigService();
givenNoMoreRecords(when(consumer.poll(any())));
givenNoMoreRecords(when(consumer.poll(any())), noMoreLatch);
configService.startAsync().awaitRunning();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Isn't this where the action happens? If so, would this be better suited for "when"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose so! I thought that the "action" happens when stopAsync() is called (e.g. it calls triggerShutdown which in turn causes the wakeup/close, but I think it makes sense to put it in "when' as well. Will make that change.

@agavra agavra requested a review from a team August 14, 2019 22:05
@agavra agavra force-pushed the connect_describe branch 2 times, most recently from 4e2da68 to 80b0a8f Compare August 15, 2019 00:00
Copy link
Contributor

@cpettitt-confluent cpettitt-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty close to me. I think some doc or other clarification on the output of describe would be super helpful. What do you think?

Copy link
Contributor

@cpettitt-confluent cpettitt-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "KSQL Sources" for now. Otherwise LGTM.

Copy link
Contributor

@cpettitt-confluent cpettitt-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agavra agavra merged commit a79adb4 into confluentinc:master Aug 16, 2019
@agavra agavra deleted the connect_describe branch August 16, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants