-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window bounds such be accessible in projection for aggregated windowed joins #5931
Comments
Note, it is the result of the join The current implementation, which attempts to first analysis the query and then build a logical plan, fails to correctly handle this combination of JOIN + Windowed Aggregation. Enhancing it to support this may be tricky as later code expects all columns to come from either It may be possible to extend the current model, or it may be better to move the validation of columns into the logical model. The query analyser requires lots of conditional logic to handle different query types. This is painful to maintain and enhance. Moving the validation to the logical model would allow us to leverage the power of polymorphism. |
fixes: #5898 This change fixes a regression introduced in v5.5.0 that meant any windowed aggregation with a join would fail with an `IllegalArgumentException`. This change fixes the regression, how ever follow on work is required to allow access to the window bounds columns `WINDOWSTART` and `WINDOWEND` in such queries. Access to these columns was not possible in v5.4, i.e. this is not a regression. The follow on work will be tracked under #5931.
Added to the structured keys project so that its picked up eventually if the triage doesn't rate this as an important thing to fix asap. |
Duplicate of #4397? |
As mentioned in #7369, at minimum the error message here stands to be improved. |
A query that includes a join and a windowed aggregation should allow users to access the window bounds columns in the projection, e.g.
Unfortunately, this currently fails with an unknown column error on
WINDOWSTART
.The following QTT test case highlights this:
The text was updated successfully, but these errors were encountered: