-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: delimited format should write decimals in a format it can read (#…
…6238) * fix: delimited format should write decimals in a format it can read fixes: #6234 The `DELIMITED` format no longer writes `DECIMAL` numbers using thousand separators. Decimals are simply written as numbers. For example, what was previously serialized as `"1,234,567.89"` is now serialized as `1234567.89`. Co-authored-by: Andy Coates <big-andy-coates@users.noreply.github.com>
- Loading branch information
1 parent
0ee402f
commit 626965e
Showing
18 changed files
with
492 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201 changes: 201 additions & 0 deletions
201
...esources/historical_plans/delimited_-_read_written_decimals/6.1.0_1600810119520/plan.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| { | ||
| "plan" : [ { | ||
| "@type" : "ksqlPlanV1", | ||
| "statementText" : "CREATE STREAM INPUT (ID STRING KEY, V DECIMAL(33, 16)) WITH (KAFKA_TOPIC='test_topic', VALUE_FORMAT='DELIMITED');", | ||
| "ddlCommand" : { | ||
| "@type" : "createStreamV1", | ||
| "sourceName" : "INPUT", | ||
| "schema" : "`ID` STRING KEY, `V` DECIMAL(33, 16)", | ||
| "topicName" : "test_topic", | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "orReplace" : false | ||
| } | ||
| }, { | ||
| "@type" : "ksqlPlanV1", | ||
| "statementText" : "CREATE STREAM INTERMEDIATE AS SELECT *\nFROM INPUT INPUT\nEMIT CHANGES", | ||
| "ddlCommand" : { | ||
| "@type" : "createStreamV1", | ||
| "sourceName" : "INTERMEDIATE", | ||
| "schema" : "`ID` STRING KEY, `V` DECIMAL(33, 16)", | ||
| "topicName" : "INTERMEDIATE", | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "orReplace" : false | ||
| }, | ||
| "queryPlan" : { | ||
| "sources" : [ "INPUT" ], | ||
| "sink" : "INTERMEDIATE", | ||
| "physicalPlan" : { | ||
| "@type" : "streamSinkV1", | ||
| "properties" : { | ||
| "queryContext" : "INTERMEDIATE" | ||
| }, | ||
| "source" : { | ||
| "@type" : "streamSelectV1", | ||
| "properties" : { | ||
| "queryContext" : "Project" | ||
| }, | ||
| "source" : { | ||
| "@type" : "streamSourceV1", | ||
| "properties" : { | ||
| "queryContext" : "KsqlTopic/Source" | ||
| }, | ||
| "topicName" : "test_topic", | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "sourceSchema" : "`ID` STRING KEY, `V` DECIMAL(33, 16)" | ||
| }, | ||
| "keyColumnNames" : [ "ID" ], | ||
| "selectExpressions" : [ "V AS V" ] | ||
| }, | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "topicName" : "INTERMEDIATE" | ||
| }, | ||
| "queryId" : "CSAS_INTERMEDIATE_0" | ||
| } | ||
| }, { | ||
| "@type" : "ksqlPlanV1", | ||
| "statementText" : "CREATE STREAM OUTPUT AS SELECT *\nFROM INTERMEDIATE INTERMEDIATE\nEMIT CHANGES", | ||
| "ddlCommand" : { | ||
| "@type" : "createStreamV1", | ||
| "sourceName" : "OUTPUT", | ||
| "schema" : "`ID` STRING KEY, `V` DECIMAL(33, 16)", | ||
| "topicName" : "OUTPUT", | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "orReplace" : false | ||
| }, | ||
| "queryPlan" : { | ||
| "sources" : [ "INTERMEDIATE" ], | ||
| "sink" : "OUTPUT", | ||
| "physicalPlan" : { | ||
| "@type" : "streamSinkV1", | ||
| "properties" : { | ||
| "queryContext" : "OUTPUT" | ||
| }, | ||
| "source" : { | ||
| "@type" : "streamSelectV1", | ||
| "properties" : { | ||
| "queryContext" : "Project" | ||
| }, | ||
| "source" : { | ||
| "@type" : "streamSourceV1", | ||
| "properties" : { | ||
| "queryContext" : "KsqlTopic/Source" | ||
| }, | ||
| "topicName" : "INTERMEDIATE", | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "sourceSchema" : "`ID` STRING KEY, `V` DECIMAL(33, 16)" | ||
| }, | ||
| "keyColumnNames" : [ "ID" ], | ||
| "selectExpressions" : [ "V AS V" ] | ||
| }, | ||
| "formats" : { | ||
| "keyFormat" : { | ||
| "format" : "KAFKA" | ||
| }, | ||
| "valueFormat" : { | ||
| "format" : "DELIMITED" | ||
| } | ||
| }, | ||
| "topicName" : "OUTPUT" | ||
| }, | ||
| "queryId" : "CSAS_OUTPUT_1" | ||
| } | ||
| } ], | ||
| "configs" : { | ||
| "ksql.extension.dir" : "ext", | ||
| "ksql.streams.cache.max.bytes.buffering" : "0", | ||
| "ksql.security.extension.class" : null, | ||
| "metric.reporters" : "", | ||
| "ksql.transient.prefix" : "transient_", | ||
| "ksql.query.status.running.threshold.seconds" : "300", | ||
| "ksql.streams.default.deserialization.exception.handler" : "io.confluent.ksql.errors.LogMetricAndContinueExceptionHandler", | ||
| "ksql.output.topic.name.prefix" : "", | ||
| "ksql.query.pull.enable.standby.reads" : "false", | ||
| "ksql.query.error.max.queue.size" : "10", | ||
| "ksql.internal.topic.min.insync.replicas" : "1", | ||
| "ksql.streams.shutdown.timeout.ms" : "300000", | ||
| "ksql.internal.topic.replicas" : "1", | ||
| "ksql.insert.into.values.enabled" : "true", | ||
| "ksql.query.pull.max.allowed.offset.lag" : "9223372036854775807", | ||
| "ksql.query.pull.max.qps" : "2147483647", | ||
| "ksql.access.validator.enable" : "auto", | ||
| "ksql.streams.bootstrap.servers" : "localhost:0", | ||
| "ksql.query.pull.metrics.enabled" : "false", | ||
| "ksql.create.or.replace.enabled" : "true", | ||
| "ksql.metrics.extension" : null, | ||
| "ksql.hidden.topics" : "_confluent.*,__confluent.*,_schemas,__consumer_offsets,__transaction_state,connect-configs,connect-offsets,connect-status,connect-statuses", | ||
| "ksql.cast.strings.preserve.nulls" : "true", | ||
| "ksql.authorization.cache.max.entries" : "10000", | ||
| "ksql.pull.queries.enable" : "true", | ||
| "ksql.suppress.enabled" : "false", | ||
| "ksql.sink.window.change.log.additional.retention" : "1000000", | ||
| "ksql.readonly.topics" : "_confluent.*,__confluent.*,_schemas,__consumer_offsets,__transaction_state,connect-configs,connect-offsets,connect-status,connect-statuses", | ||
| "ksql.query.persistent.active.limit" : "2147483647", | ||
| "ksql.persistence.wrap.single.values" : null, | ||
| "ksql.authorization.cache.expiry.time.secs" : "30", | ||
| "ksql.query.retry.backoff.initial.ms" : "15000", | ||
| "ksql.schema.registry.url" : "", | ||
| "ksql.properties.overrides.denylist" : "", | ||
| "ksql.streams.auto.offset.reset" : "earliest", | ||
| "ksql.connect.url" : "http://localhost:8083", | ||
| "ksql.service.id" : "some.ksql.service.id", | ||
| "ksql.streams.default.production.exception.handler" : "io.confluent.ksql.errors.ProductionExceptionHandlerUtil$LogAndFailProductionExceptionHandler", | ||
| "ksql.enable.metastore.backup" : "false", | ||
| "ksql.streams.commit.interval.ms" : "2000", | ||
| "ksql.streams.auto.commit.interval.ms" : "0", | ||
| "ksql.streams.topology.optimization" : "all", | ||
| "ksql.query.retry.backoff.max.ms" : "900000", | ||
| "ksql.streams.num.stream.threads" : "4", | ||
| "ksql.timestamp.throw.on.invalid" : "false", | ||
| "ksql.metrics.tags.custom" : "", | ||
| "ksql.udfs.enabled" : "true", | ||
| "ksql.udf.enable.security.manager" : "true", | ||
| "ksql.connect.worker.config" : "", | ||
| "ksql.udf.collect.metrics" : "false", | ||
| "ksql.persistent.prefix" : "query_", | ||
| "ksql.metastore.backup.location" : "", | ||
| "ksql.error.classifier.regex" : "", | ||
| "ksql.suppress.buffer.size.bytes" : "-1" | ||
| } | ||
| } |
Oops, something went wrong.