Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add confluent-hub to ksqldb server and cli images #40

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Mar 13, 2020

^ for consistency with the community ksqlDB images (confluentinc/ksql#4729).

Slack conversation: https://confluent.slack.com/archives/C8486MR1C/p1584107074300800?thread_ts=1584048653.296300&cid=C8486MR1C

Note that this change is targeted at master and not 5.5, so the change will only be available starting in 6.0 (or whatever the next release after 5.5 is).

@vcrfxia vcrfxia requested review from a team and colinhicks March 13, 2020 17:51
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @vcrfxia

Copy link

@colinhicks colinhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @vcrfxia. Thank you!

@vcrfxia vcrfxia merged commit 8a0504b into master Mar 13, 2020
@vcrfxia vcrfxia deleted the vxia-confluent-hub branch March 13, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants