CPBR-2254 Stop building and publishing confluentinc/cp-enterprise-kafka docker image starting CP 8.0 #375
Conversation
wadhwa1
commented
Mar 3, 2025
•
- Stop building and publishing confluentinc/cp-enterprise-kafka image from CP 8.0, more details in https://confluentinc.atlassian.net/browse/CPBR-2254
- PR checks will fail, as we don't have a green packaging build yet for master branch
… docker image starting CP 8.0
There was a problem hiding this comment.
PR Overview
This PR stops building and publishing the confluentinc/cp-enterprise-kafka docker image starting with CP 8.0 by removing related promotion, deployment, and test configurations.
- Removed promotion and manifest creation steps for enterprise-kafka in the Semaphore CI YAML files
- Excluded enterprise-kafka from the DOCKER_REPOS list and removed its deploy job entries
- Eliminated the enterprise-kafka test suite, setup.py, and README
Reviewed Changes
| File | Description |
|---|---|
| .semaphore/cp_dockerfile_promote.yml | Removed promotion steps for cp-enterprise-kafka |
| .semaphore/cp_dockerfile_build.yml | Excluded cp-enterprise-kafka from build repos and deploy tasks |
| service.yml | Removed cp-enterprise-kafka service references |
| .semaphore/semaphore.yml | Updated repository lists to remove cp-enterprise-kafka |
| ce-kafka/test/test_enterprise_kafka.py | Deleted enterprise-kafka tests |
| ce-kafka/setup.py | Removed setup config for enterprise-kafka tests |
| ce-kafka/README.md | Deleted README for the deprecated enterprise-kafka image |
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.semaphore/cp_dockerfile_build.yml:81
- Verify that the updated, multiline DOCKER_REPOS variable is correctly parsed by the shell and does not introduce unintended whitespace or newline issues.
- export DOCKER_REPOS="confluentinc/cp-server-connect confluentinc/cp-server-connect-base confluentinc/cp-kafka-connect confluentinc/cp-kafka-connect-base confluentinc/cp-kafka
ce-kafka/test/test_enterprise_kafka.py:1
- The complete removal of enterprise-kafka tests is intentional; please ensure that the overall test suite and CI configurations are updated to reflect this change to avoid inadvertent gaps in coverage.
import os
| @@ -83,4 +82,3 @@ code_artifact: | |||
| - maven-snapshots/maven/io.confluent.kafka-images/cp-kafka-connect-base | |||
| - maven-snapshots/maven/io.confluent.kafka-images/cp-kafka-connect | |||
| - maven-snapshots/maven/io.confluent.kafka-images/cp-kafka | |||
| - maven-snapshots/maven/io.confluent.kafka-images/cp-enterprise-kafka | |||
There was a problem hiding this comment.
will removing this break docker build workflows for CP 7.x branches?
There was a problem hiding this comment.
hmm good point, we can configure service.yml file differently for each of our release branches..
so i assumed this should work unless there’s some restriction/ limitation on how code artifact package path configuration works, does it only respect and pick config from master branch..
i’ve asked devprod-oncall to clarify this https://confluent.slack.com/archives/C09EP1SS3/p1741157167054199
let’s see, else i’ll add back this additional package path, there’s no harm in keeping the deprecated ones i believe