pre-install-payload: Use latest tagged runtime-payload image #255
Conversation
|
/test |
There was a problem hiding this comment.
lgtm, thanks @mattarnoatibm!
Just one comment that I think using latest is fine, but we need to tag to a specific version during the release.
There was a problem hiding this comment.
Hey Matt,
Whilst the previous PR should have probably set the tag to latest as it was self-dependent, can you point at the e45d4e84c3ce4ae116f3f4d6c123c4829606026f tag now please as it gives us more stability.
Also, the ssh-demo/kustomization.yaml (config/samples/ccruntime/ssh-demo/kustomization.yaml) wasn't bumped last time, so can you fix that in this commit too please.
Thanks!
Fabiano has suggested we could change it later, so up to you, but if you are adding ssh-demo, then it might be easiest to bump it now in prep for release. |
|
I'll update this PR to set the reqs-payload to e45d4e8. Thanks for the feedback Steve and Fabiano. |
Choose a runtime-payload image tag that has all the scripts in the right place and shouldn't go into a crash loop when you run it as part of the operator installation. Signed-off-by: Matthew Arnold <mattarno@uk.ibm.com>
73aff01 to
0060556
Compare
|
/test |
The tags for the quay.io/confidential-containers/reqs-payload image were not set to the latest tag and were set to the tag of an image that went into a crash loop when you ran it as part of the operator installation.
Fixes: #254