controller: Ensure the runtimeclass was created by the payload #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'kustomize edit set image' step needs to specify the correct 'name' to override before the '=' sign otherwise it only overrides the tag for the image. The previous version results in this entry (which does nothing to the manifest) images: - name: localhost:5000/cc-operator newTag: latest and the new version does this: images: - name: quay.io/confidential-containers/operator newName: localhost:5000/cc-operator newTag: latest The 'name' needs to be the quay entry and not 'controller' because there is already a previous override in config/manager/kustomization.yaml. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
The kind cluster is connected to a different bridge than the registry , which means the kind cluster can't pull from 'localhost:5000'. Connect the registry to the same kind bridge and use the container name as a mirror for 'localhost' so that pulling works. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
36664b5 introduced a regression as the runtimeClass creation was left to the runtime payload, but we never checked whether this actually was created neither updated the status on the Operator side. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
a4aba3f to
fbc66fb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
36664b5 introduced a regression as the runtimeClass creation was left to the runtime payload, but we never checked whether this actually was created neither updated the status on the Operator side.