-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccruntime: Adapt to the kata payload using /opt/kata
#235
Merged
fidencio
merged 2 commits into
confidential-containers:main
from
fidencio:topic/adapt-to-kata-payload-using-opt-kata
Jul 28, 2023
Merged
ccruntime: Adapt to the kata payload using /opt/kata
#235
fidencio
merged 2 commits into
confidential-containers:main
from
fidencio:topic/adapt-to-kata-payload-using-opt-kata
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change that's been done as part of the CCv0, and it'll simplify a lot the co-existence of the `CCv0` and `main` branch during this time that we're moving things from `CCv0` to `main`. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
wainersm
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad it seems a trivial change :)
/test |
/test |
3b04e4e
to
a8de3f1
Compare
/test |
zvonkok
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fair and simple enough
This is needed as we want to test against the latest payload generated, not against the latest released one. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
a8de3f1
to
3e26c7e
Compare
/test |
ebe8988
to
3e26c7e
Compare
/test |
2 similar comments
/test |
/test |
247fe88
to
3e26c7e
Compare
I updated as I removed the debug commit. /test |
arronwy
approved these changes
Jul 28, 2023
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change that's been done as part of the CCv0, and it'll simplify a lot the co-existence of the
CCv0
andmain
branch during this time that we're moving things fromCCv0
tomain
.This pull request is marked as a Draft because it depends on kata-containers/kata-containers#7402 getting merged and having a payload generated from it.