Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccruntime: Adapt to the kata payload using /opt/kata #235

Conversation

fidencio
Copy link
Member

This is a change that's been done as part of the CCv0, and it'll simplify a lot the co-existence of the CCv0 and main branch during this time that we're moving things from CCv0 to main.

This pull request is marked as a Draft because it depends on kata-containers/kata-containers#7402 getting merged and having a payload generated from it.

This is a change that's been done as part of the CCv0, and it'll
simplify a lot the co-existence of the `CCv0` and `main` branch during
this time that we're moving things from `CCv0` to `main`.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad it seems a trivial change :)

@fidencio
Copy link
Member Author

/test

@fidencio fidencio marked this pull request as ready for review July 26, 2023 05:40
@fidencio
Copy link
Member Author

/test

@fidencio fidencio force-pushed the topic/adapt-to-kata-payload-using-opt-kata branch from 3b04e4e to a8de3f1 Compare July 26, 2023 13:29
@fidencio
Copy link
Member Author

/test

Copy link
Member

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fair and simple enough

This is needed as we want to test against the latest payload generated,
not against the latest released one.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@fidencio fidencio force-pushed the topic/adapt-to-kata-payload-using-opt-kata branch from a8de3f1 to 3e26c7e Compare July 27, 2023 06:43
@fidencio
Copy link
Member Author

/test

@fidencio fidencio force-pushed the topic/adapt-to-kata-payload-using-opt-kata branch from ebe8988 to 3e26c7e Compare July 27, 2023 17:37
@fidencio
Copy link
Member Author

/test

2 similar comments
@fidencio
Copy link
Member Author

/test

@BbolroC
Copy link
Member

BbolroC commented Jul 28, 2023

/test

@fidencio fidencio force-pushed the topic/adapt-to-kata-payload-using-opt-kata branch from 247fe88 to 3e26c7e Compare July 28, 2023 10:14
@fidencio
Copy link
Member Author

I updated as I removed the debug commit.

/test

@fidencio
Copy link
Member Author

/test

@fidencio fidencio merged commit 2efecdf into confidential-containers:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants