Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update dependencies + drop custom kind node image #227

Merged
merged 3 commits into from
Sep 1, 2023
Merged

go.mod: update dependencies + drop custom kind node image #227

merged 3 commits into from
Sep 1, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Jul 20, 2023

No description provided.

@mythi mythi force-pushed the go-mod-update branch 6 times, most recently from 3e85657 to d5920cb Compare July 24, 2023 14:58
@mythi mythi changed the title go.mod: update dependencies go.mod: update dependencies + drop custom kind node image Aug 15, 2023
@mythi mythi mentioned this pull request Aug 16, 2023
Closed
@mythi
Copy link
Contributor Author

mythi commented Aug 25, 2023

updated to v1.27.5 and rebased. this is ready for the release

@fidencio
Copy link
Member

/test

fidencio
fidencio approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mythi!

@fidencio
Copy link
Member

/test

1 similar comment
@fidencio
Copy link
Member

/test

bpradipt
bpradipt approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @mythi

@fidencio
Copy link
Member

fidencio commented Sep 1, 2023

/test

@fidencio
Copy link
Member

fidencio commented Sep 1, 2023

@mythi, so, the tests are failing because we'll require a newer version of golang (v1.20) after your patches.
You'll also need to update https://github.com/confidential-containers/operator/blob/main/tests/e2e/ansible/group_vars/all#L13

mythi added 3 commits September 1, 2023 17:21
@mythi
use Go 1.20.x
cb50983 
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi
go.mod: update dependencies
bd188a5 
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi
e2e: drop custom kind node image
194e789 
The node image does not need dbus installed anymore after
we moved to use host systemctl so the vanilla kind node image
works fine again.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@fidencio
Copy link
Member

fidencio commented Sep 1, 2023

/test

@fidencio
Copy link
Member

fidencio commented Sep 1, 2023 •
edited
Loading

TDX is failing, the failure is not related tot this PR, and I've opened #257 to track it.

@fidencio fidencio merged commit 9080fe4 into confidential-containers:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@bpradipt bpradipt bpradipt approved these changes

@wainersm wainersm Awaiting requested review from wainersm

Assignees

@mythi mythi

Labels
None yet
Projects
CoCo Releases
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythi @fidencio @bpradipt