Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install/pre-install: Update containerd #225

Merged
merged 3 commits into from
Jul 19, 2023
Merged

install/pre-install: Update containerd #225

merged 3 commits into from
Jul 19, 2023

Conversation

stevenhorsman
Copy link
Member

Update containerd version now we have a new release

@stevenhorsman
install/pre-install: Update containerd
ab910dc 
Update containerd version now we have a new release

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
zvonkok
zvonkok approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@stevenhorsman
Copy link
Member Author

/test

@stevenhorsman
Copy link
Member Author

Given that #179 hasn't been merged we aren't actually testing the pre-install image, so any failures aren't related to the change

@wainersm
Copy link
Member

I am trying to get #179 merged first. Let's wait a little bit, end of the day maybe.

@wainersm wainersm mentioned this pull request Jul 18, 2023
Closed
@wainersm
Copy link
Member

Given that #179 hasn't been merged we aren't actually testing the pre-install image, so any failures aren't related to the change

I've faced issues to merge #179. So I opened #226 in order to test this PR.

Lifted the do-not-merge label.

@fidencio fidencio force-pushed the bump-containerd-version branch from ab910dc to 9d0b844 Compare July 18, 2023 22:00
@wainersm
Copy link
Member

@stevenhorsman https://github.com/confidential-containers/containerd/releases/tag/v1.6.8.2 is missing the s390x build. That's why the jobs on #226 (that I am using to test this PR) are failing.

@wainersm
Copy link
Member

btw, @stevenhorsman , cf3aaef fixes a bunch of troubles I've faced to get kubectl installed on the pre-install image. If you and @jepio agree, could we pick up that fix on this PR too?

@wainersm @stevenhorsman
pre-install: pull the kubectl binary
9f2f377 
Currently we have installed the kubectl package from google cloud but it
has been problematic due to many networking and certification issues
like in below. Instead let's pull and install the kubectl binary (no
packaged).

```
10:37:14 confidential-containers#9 9.663 Err:2 https://packages.cloud.google.com/apt kubernetes-xenial InRelease
10:37:14 confidential-containers#9 9.663   The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05
10:37:14 confidential-containers#9 9.681 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
10:37:15 confidential-containers#9 9.824 Reading package lists...
10:37:15 confidential-containers#9 10.81 W: GPG error: https://packages.cloud.google.com/apt kubernetes-xenial InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05
10:37:15 confidential-containers#9 10.81 E: The repository 'https://apt.kubernetes.io/ kubernetes-xenial InRelease' is not signed.
```

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
(cherry picked from commit cf3aaef)
@stevenhorsman stevenhorsman force-pushed the bump-containerd-version branch from 9d0b844 to 9f2f377 Compare July 19, 2023 07:02
@stevenhorsman
Copy link
Member Author

/test

@stevenhorsman
Copy link
Member Author

@stevenhorsman https://github.com/confidential-containers/containerd/releases/tag/v1.6.8.2 is missing the s390x build. That's why the jobs on #226 (that I am using to test this PR) are failing.

Sorry, that's my bad. I must've removed it when updating the containerd workflow as it's only in 1.7, not 1.6. I will look at that right now.

@stevenhorsman
Copy link
Member Author

@stevenhorsman https://github.com/confidential-containers/containerd/releases/tag/v1.6.8.2 is missing the s390x build. That's why the jobs on #226 (that I am using to test this PR) are failing.

Sorry, that's my bad. I must've removed it when updating the containerd workflow as it's only in 1.7, not 1.6. I will look at that right now.

Fixed and the release re-built

@stevenhorsman
Copy link
Member Author

/test

@wainersm
Copy link
Member

@stevenhorsman https://github.com/confidential-containers/containerd/releases/tag/v1.6.8.2 is missing the s390x build. That's why the jobs on #226 (that I am using to test this PR) are failing.

Sorry, that's my bad. I must've removed it when updating the containerd workflow as it's only in 1.7, not 1.6. I will look at that right now.

I forgive you @stevenhorsman . This time only ;)

wainersm
wainersm approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can disregard the sev failure on #226 and proceed to merge here. Once the new pre-install image is built then we will have the opportunity to test it on sev too.

@wainersm wainersm merged commit c80c3e7 into confidential-containers:main Jul 19, 2023
@wainersm wainersm mentioned this pull request Jul 19, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainersm wainersm wainersm approved these changes

@zvonkok zvonkok zvonkok approved these changes

@jepio jepio jepio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenhorsman @wainersm @zvonkok @jepio