Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Add runtimeclass kata-qemu-se #191

Merged
merged 1 commit into from
Jun 30, 2023
Merged

config: Add runtimeclass kata-qemu-se #191

merged 1 commit into from
Jun 30, 2023

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Mar 31, 2023

This is to add a new runtimeclass kata-qemu-se and update its payload image for e2e test.

Fixes: #190

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@BbolroC BbolroC force-pushed the runtime-class-se branch from 9efb4d0 to 51faafc Compare April 4, 2023 16:07
@fidencio
Copy link
Member

fidencio commented Apr 6, 2023

/test

fidencio
fidencio approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @BbolroC!

@BbolroC BbolroC force-pushed the runtime-class-se branch 3 times, most recently from 7740af0 to b448b95 Compare April 12, 2023 11:48
@BbolroC BbolroC force-pushed the runtime-class-se branch 2 times, most recently from 7bcb89c to 0b848b9 Compare June 12, 2023 11:48
fidencio
fidencio requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding the requested-changes based on the comment I made.

@BbolroC BbolroC force-pushed the runtime-class-se branch 2 times, most recently from fd2160f to 6ba4af0 Compare June 19, 2023 12:35
@BbolroC BbolroC changed the title WIP config: Add runtimeclass kata-qemu-se config: Add runtimeclass kata-qemu-se Jun 19, 2023
@BbolroC BbolroC force-pushed the runtime-class-se branch from 6ba4af0 to 998c070 Compare June 19, 2023 12:45
@BbolroC BbolroC requested a review from fidencio June 19, 2023 13:41
stevenhorsman
stevenhorsman approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine generally, just a couple of minor comments

tests/e2e/tests_runner.sh Outdated Show resolved Hide resolved
tests/e2e/tests_runner.sh Outdated Show resolved Hide resolved
@BbolroC BbolroC force-pushed the runtime-class-se branch from 998c070 to 4156fec Compare June 19, 2023 16:36
stevenhorsman
stevenhorsman approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stevenhorsman
Copy link
Member

/test

@stevenhorsman
Copy link
Member

/test
/test-tdx

@BbolroC
config: Add runtimeclass kata-qemu-se
cf1ba38 
This is to add a new runtimeclass `kata-qemu-se` and update its payload
image for e2e test.

Fixes: confidential-containers#190

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC force-pushed the runtime-class-se branch from 4156fec to cf1ba38 Compare June 20, 2023 17:31
@BbolroC
Copy link
Member Author

BbolroC commented Jun 20, 2023

Sorry for the re-push. I thought that an update on the payload image at:

operator/config/samples/ccruntime/default/kustomization.yaml

Lines 9 to 14 in 83b5134

images:
- name: quay.io/confidential-containers/container-engine-for-cc-payload
newTag: 98a790e8abdcc06c4b629b290ebaa217bf82e305
- name: quay.io/confidential-containers/runtime-payload
newName: quay.io/confidential-containers/runtime-payload
newTag: kata-containers-338e18e4fd46756643cb1a307b6a20f24c350ad4

would unexpectedly break the CI for s390x someday.

A secure image is only available at quay.io/confidential-containers/runtime-payload-ci for testing purposes. So I've configured an image and a tag at config/samples/ccruntime/s390x.

@stevenhorsman
Copy link
Member

/test

@stevenhorsman
Copy link
Member

@arronwy, @fidencio - whoever is back from vacation first are you able to check if the tdx failures are related to this PR (which seems unlikely), or just infrastructure issues? Thanks!

@arronwy
Copy link
Member

arronwy commented Jun 22, 2023

@arronwy, @fidencio - whoever is back from vacation first are you able to check if the tdx failures are related to this PR (which seems unlikely), or just infrastructure issues? Thanks!

Hi @stevenhorsman ， the failure is not related to this PR, TDX CLH CI passed but hangs on uninstall the operator.

fidencio
fidencio approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @BbolroC!

@fidencio fidencio merged commit 4c8a21b into confidential-containers:main Jun 30, 2023
@BbolroC BbolroC deleted the runtime-class-se branch July 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@arronwy arronwy arronwy approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/e2e: Add e2e test for s390x TEE (IBM SE)
4 participants
@BbolroC @fidencio @stevenhorsman @arronwy