Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rand from 0.8.5 to 0.9.0 #900

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

Xynnn007
Copy link
Member

New rand crate changes

  • sub module distributions renamed to distr
  • api thread_rng renamed to rng
  • OsRng now only supports TryRngCore (probably catch an error)

Manually & Close #898

@Xynnn007 Xynnn007 requested a review from a team as a code owner February 10, 2025 07:13
New rand crate changes
- sub module distributions renamed to distr
- api thread_rng renamed to rng
- OsRng now only supports TryRngCore (probably catch an error)

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 marked this pull request as draft February 10, 2025 07:29
rand_core 0.9.0 has different API definition for rng thus cannot fit in
the rsa::RsaPrivateKey::new(). This patch directly use OsRng exposed by
rsa crate.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 marked this pull request as ready for review February 10, 2025 07:52
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update

@Xynnn007 Xynnn007 merged commit f76ced9 into confidential-containers:main Feb 11, 2025
20 checks passed
@Xynnn007 Xynnn007 deleted the chore-rand branch February 12, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants