Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attester: rename check_init_data => bind_init_data #769

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Oct 28, 2024

This change generalizes the concept of binding init_data to the TEE evidence. In SNP and TDX attesters this currently happens via equality checks on the HW report's HOSTDATA/MRCONFIGID fields.

On vTPM attester modules or other attesters which do not allow setting similar fields, the binding can be performed by extending the HW evidence.

@mkulke mkulke requested a review from a team as a code owner October 28, 2024 12:26
@mkulke mkulke force-pushed the mkulke/support-extending-pcrs-for-initdata-bind branch 3 times, most recently from 87df6be to c1b9a44 Compare October 28, 2024 12:49
This change generalizes the concept of binding init_data to the TEE
evidence. In SNP and TDX attesters this currently happens via equality
checks on the HW report's HOSTDATA/MRCONFIGID fields.

On vTPM attester modules or other attesters which do not allow
setting similar fields, the binding can be performed by extending the
HW evidence.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/support-extending-pcrs-for-initdata-bind branch from c1b9a44 to 70016f9 Compare October 28, 2024 13:03
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkulke mkulke merged commit 89da8e5 into confidential-containers:main Oct 29, 2024
9 checks passed
@mkulke mkulke deleted the mkulke/support-extending-pcrs-for-initdata-bind branch October 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants