Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring new test images for CI #140

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Mar 29, 2023

Fixes: #130

@Xynnn007 Xynnn007 requested a review from a team as a code owner March 29, 2023 09:51
@Xynnn007 Xynnn007 force-pushed the feat-uri branch 2 times, most recently from e4f02f3 to 5ca7311 Compare March 30, 2023 02:53
@Xynnn007 Xynnn007 force-pushed the feat-uri branch 3 times, most recently from 0d1d12c to 41e28e2 Compare April 2, 2023 13:10
@Xynnn007 Xynnn007 mentioned this pull request Apr 2, 2023
@Xynnn007
Copy link
Member Author

Xynnn007 commented Apr 4, 2023

I have replaced the test image with the one of community. However, that one is not signed by cosign now. I will use the policy

{
    "default": [{"type": "reject"}], 
    "transports": {
        "docker": {
            "ghcr.io/confidential-containers": [
                {
                    "type": "insecureAcceptAnything"
                }
            ]
        }
    }
}

which means the image will be accepted without signature verification.

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some minor comments. Can you squash some of the commits (e.g., image-rs + Cargo updates)

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 force-pushed the feat-uri branch 3 times, most recently from 02a59d3 to c544e77 Compare April 11, 2023 06:56
Fixes confidential-containers#108

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@mythi mythi merged commit d4cf19a into confidential-containers:main Apr 12, 2023
@Xynnn007 Xynnn007 deleted the feat-uri branch April 12, 2023 07:29
@mythi
Copy link
Contributor

mythi commented Apr 12, 2023

@Xynnn007 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roadmap to support new image format for eaa-kbc
2 participants