Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect assignment of Image ID #2291

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Fix incorrect assignment of Image ID #2291

merged 3 commits into from
Feb 10, 2025

Conversation

bpradipt
Copy link
Member

@bpradipt bpradipt commented Feb 10, 2025 •
edited by stevenhorsman
Loading

Fixes #2284

@bpradipt bpradipt marked this pull request as ready for review February 10, 2025 06:59
@bpradipt bpradipt requested a review from a team as a code owner February 10, 2025 06:59
stevenhorsman
stevenhorsman approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bpradipt for the fix & @wainersm for the testing that found it!

@bpradipt
aws: Fix incorrect assignment of ImageId
fd69dab 
The image specified in the annotation was incorrectly overriding the
default cluster wide config.

Drive-by fix: fix var name for ConfigVerifier

Fixes: confidential-containers#2284

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt
azure: Fix incorrect assignment of ImageId
b9de6a8 
The image specified in the annotation was incorrectly overriding the
default cluster wide config.

Drive-by fix: fix var name for ConfigVerifier

Fixes: confidential-containers#2284

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@wainersm
Copy link
Member

Hi @bpradipt , thanks for the quick fix!

On minor fix, the commit of the 3rd commit (608e318) , the subsystem in the subject should be ibmcloud-powervs

@bpradipt
ibm-powervs: Fix incorrect assignment of ImageId
93f8ab2 
The image specified in the annotation was incorrectly overriding the
default cluster wide config.

Drive-by fix: fix var name for ConfigVerifier

Fixes: confidential-containers#2284

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt bpradipt merged commit deabbfe into confidential-containers:main Feb 10, 2025
22 checks passed
@bpradipt bpradipt deleted the fix-2284 branch February 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@wainersm wainersm wainersm approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io.katacontainers.config.hypervisor.image pod annotation updates CAA globally
4 participants
@bpradipt @wainersm @mkulke @stevenhorsman