Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: introducing provisioning code and tests #2290

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

beraldoleal
Copy link
Member

This adds the initial GCP provisioning code along with some basic E2E tests. Still a work in progress, so marking as a draft while things get sorted out.

@beraldoleal
Copy link
Member Author

beraldoleal commented Feb 8, 2025

@stevenhorsman @wainersm Better late than never, clearing an old debt here.

I'll continue working on this next week, but if you have any insight into why this commit is returning an error here, that would be helpful.

Since no one has reported this issue and CI is still running fine, it makes me think the problem is on my side, but it's Friday night and my brain has shut down.

@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch from b8d78d7 to fa936ba Compare February 8, 2025 02:08
@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch 3 times, most recently from d443b92 to a9f14fe Compare February 10, 2025 21:32
@beraldoleal
Copy link
Member Author

I'll continue working on this next week, but if you have any insight into why this commit is returning an error here, that would be helpful.
Since no one has reported this issue and CI is still running fine, it makes me think the problem is on my side, but it's Friday night and my brain has shut down.

Yes, it was on my side! kubectl version was not supporting the syntax used here. Solved already.

@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch 2 times, most recently from f727e9e to 1badc87 Compare February 13, 2025 16:59
Currently, this field is ignored and using 'default' network instead.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
Moving essential vars above.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
Common methods used by gcp provider.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch from 1badc87 to 0f61fdb Compare February 13, 2025 17:02
@beraldoleal beraldoleal marked this pull request as ready for review February 13, 2025 17:02
@beraldoleal beraldoleal requested a review from a team as a code owner February 13, 2025 17:02
@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch from 0f61fdb to 4225d53 Compare February 13, 2025 17:05
This will create a GKE cluster and vpc within GCP.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
For now, those are the basic tests we are adding.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
Making CI happy

Signed-off-by: Beraldo Leal <bleal@redhat.com>
@beraldoleal beraldoleal force-pushed the gcp-introducing-tests branch from 4225d53 to f3b040b Compare February 13, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant