Update kbs-client package name for oras #2278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming scheme for the kbs-client package has changed, so oras-pull must be updated here. Signed-off-by: Chris Porter <porter@ibm.com>
2d244fb to
36b7671
Compare
|
Hi @portersrc - thanks for the head's up on this, it would have been a tricky one to debug. We need to put a hold on this as we can't take the change until we update the trustee version to be at/after the commit that your change when it otherwise it will break us. |
|
got it; yeah it seemed to be a minor change but an obnoxious sync'ing problem; sorry for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release process was skipping kbs-client, so I made the fix in trustee here. While fixing it, I noticed the package naming was slightly inconsistent with other packages, so I updated it. I found one place in our code base -- right here in cloud-api-adaptor -- that might be affected. Maybe @stevenhorsman PTAL? I don't know what triggers this script and
oras pullin cloud-api-adaptor.