Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add podvm-smoketest workflow #2247

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Jan 16, 2025

This workflow will build a podvm image, launch a vm and then attempt to address it via the kata agent API.

This should give earlier signals of podvm problems and can run on PRs.

nb: the wf is running on 22.04 b/c libvirt struggles with OVMF_CODE_4M firmware that is default on ub 24.04.

@mkulke mkulke requested a review from a team as a code owner January 16, 2025 18:25
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ..

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great addition. Thanks a lot for actioning it so quickly!

.github/workflows/podvm_smoketest.yaml Show resolved Hide resolved
Comment on lines +16 to +22
# Required by rootless mkosi on Ubuntu 24.04
# - name: Un-restrict user namespaces
# run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a reference for developers trying to do this manually, or potentially for future when we can migrate to 24.04 after the OVMF firmware issues are resolved?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latter, because we'd probably forget about this

Comment on lines +50 to +56
- name: Disable TLS for agent-protocol-forwarder
run: |
mkdir -p ./resources/binaries-tree/etc/default
echo "TLS_OPTIONS=-disable-tls" > ./resources/binaries-tree/etc/default/agent-protocol-forwarder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is a candidate to also enable in the "developer mode" I'm thinking of in #2227
I'm trying to work out if there would be value in reusing the current podvm_mkosi workflow to help do this image build section, but we'd need to add support for that in. This isn't a blocker for this PR, just thinking about it whilst reviewing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, although I'm not convinced we require a build-time flag for TLS. An empty tls config in daemon.json should just indicate that we're not using TLS.

@mkulke mkulke force-pushed the mkulke/podvm-smoketest branch from ea6fa8e to 2d52b93 Compare January 17, 2025 09:42
This workflow will set build a podvm image, launch a vm and then attempt
to address it via the kata agent API.

This should give earlier signals on the podvm problems and can run on
PRs.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/podvm-smoketest branch from 2d52b93 to e7d55f3 Compare January 17, 2025 09:50
@mkulke mkulke merged commit d07938d into confidential-containers:main Jan 17, 2025
23 checks passed
@mkulke mkulke deleted the mkulke/podvm-smoketest branch January 17, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants