Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gpt synthetic data #74

Merged
merged 10 commits into from
Sep 1, 2023
Merged

Add gpt synthetic data #74

merged 10 commits into from
Sep 1, 2023

Conversation

penguine-ip
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evals-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:25am

jwongster2
jwongster2 suggested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jwongster2 jwongster2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please:

  • Add a a test using OpenAI env variable to make sure it works.
  • Move hard-coded parameters to the top.
  • Build in re-try for OpenAI in case it fails

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@jwongster2 jwongster2 mentioned this pull request Sep 1, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Thanks for the PR! Going to review and merge soon 😉
Just before that though can you please test the installation with the command below? 😎

pip install git+https://github.com/confident-ai/deepeval.git@features/create-synthetic-data-pair

@jwongster2 jwongster2 merged commit 235d754 into main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwongster2 jwongster2 jwongster2 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penguine-ip @jwongster2