fix: reduce tracing level for reflink #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Are these removed in production builds? I wonder about performance. Additionally, maybe it would be enough to log this once? |
|
Yeah I think it would be better to check these things up front but I created this PR now to unstuck a pixi 0.11.2 release. Ill look at a proper fix later. |
|
I think the overhead of skipped log statements is very little but Im not certain. |
|
Supposedly we could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reflinking is not supported by the filesystem users would be spammed with error logs. I've reduced their level to
debugnow.