-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to force usage of fallback_auth_store #435
Conversation
I think this is "OK" for me. Not a super-fan of the option :) I am wondering if we should rather create another authentication storage that can be supplied instead of the current one. The new one would rely only on the fallback storage and uses plain JSON as database, and then we would have a Rust trait for an authentication storage? |
Yeah, that sounds a bit more elegant. |
crates/rattler_networking/src/authentication_storage/storage.rs
Outdated
Show resolved
Hide resolved
I still need to test this with rattler-build |
Nice work! Looks good to me. If we can get rid of |
I adapted and tested the rattler-build PR with our real-world example. Works great! I also changed the file location of the |
Would you prefer to return a |
right. let's try to ask @baszalmstra what he thinks is best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, almost looks good to me. I left some small comments.
And I would just use anyhow Result.
When running within a CI, it is sometimes easier not to rely on the native authentication toolchain, but to use a simple credentials file instead (see prefix-dev/rattler-build#334). This PR adds an option to force the use of this fallback file and disable the use of the system toolchain.