fix: use filelock for authentication fallback storage #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
commented
Dec 4, 2023
| self.path.to_string_lossy() | ||
| ); | ||
| return Ok(std::collections::HashMap::new()); | ||
| static WARN_GUARD: Lazy<Mutex<HashSet<PathBuf>>> = |
There was a problem hiding this comment.
@wolfv this should ensure that the warning is only printed once per filename for the current process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for the authentication storage randomly failed. I think this was caused by multiple threads writing to the fallback storage at the same time. This was only guarded by a mutex but multiple objects referring to the same file could exists. I replaced the mutex with a filelock to ensure that the multiple threads (and processes) are synchronized.
By request I also changed the logging behavior to ensure that the warning about fallback storage is only printed once (per file).