Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the channel in the solve #391

Closed

Conversation

ruben-arts
Copy link
Collaborator

@baszalmstra what do you think of something like this?

If do an unstrict channel priority this works with solving for channel specific packges.

@ruben-arts ruben-arts marked this pull request as draft November 1, 2023 14:49
@baszalmstra
Copy link
Collaborator

I dont think this is great because it changes the API. Maybe it would make more sense to add a match to the RepoDataRecord instead? But either way, you dont know in which form the channel is in the record (could be a url, could be a name). I think it would be better to add this to the solver so users also get better feedback on why a variant wasnt selected.

@wolfv
Copy link
Contributor

wolfv commented Nov 2, 2023

@baszalmstra I was discussing with Ruben about this yesterday. My approach idea was that we would filter the selected repodatas afterwards for strict priority / channel specificity.

Once we have support in resolvo to add "disallow_rules" we can turn the filter into adding a rule for each of the disallowed packages.

Maybe you can help explain how & where we could add such a filter.

@ruben-arts
Copy link
Collaborator Author

Closed in favor of #394

@ruben-arts ruben-arts closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants