Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make archive type serialize and deserialize #388

Closed
wants to merge 3 commits into from

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Oct 30, 2023

This would be useful to serialize the rattler-build outputs.

@baszalmstra
Copy link
Collaborator

Maybe it helps to use: https://serde.rs/variant-attrs.html#rename_all ?

@wolfv
Copy link
Contributor Author

wolfv commented Oct 31, 2023

@baszalmstra would you rather have them serialized as lowercase, or as tar.bz2 / conda? I don't have a strong preference.
I more or less need this in rattler-build, but we could also skip serializing this option in rattler-build.

@baszalmstra
Copy link
Collaborator

@baszalmstra would you rather have them serialized as lowercase, or as tar.bz2 / conda? I don't have a strong preference. I more or less need this in rattler-build, but we could also skip serializing this option in rattler-build.

I have no strong preference, but I think if you serialize this to yaml the most beautiful would be snake_case perhaps?

@baszalmstra
Copy link
Collaborator

This seems to already be integrated in #392

@baszalmstra baszalmstra closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants