-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build_spec module, not yet used in match_spec #340
Conversation
Whoops, forgot to make a PR for the other two changes. I'll separate those out and then mark this as ready.
|
8c5dcb1
to
2a2837c
Compare
Nice work @YeungOnion ! I merged the first two PRs |
One of these CI failures is from not calling The only way to call it as is, would be to make all the changes in the An alternative to pass the check is to define API at crate level and use that API in this module. All types with trait Matchable {
type Record; // very open to better names
fn matches(x: &Record) -> bool;
} All the I like the second approach, but I don't see real value beyond uncoupling the PR for build number specs into one for module and the other for usage since there aren't other types yet to create that would |
Adds some formatting improvements for solvables and out logging. Also adds: - Additional tests - Reformats some of the insta tests to make them more clear (e.g. `9` becomes `foo=9`).
I think either removing it if it's unused. Or what I'm thinking you are saying is to actually change methods to use this function is a good idea. The other alternative might be a good idea, but I agree it is out of context of this PR :) But Ill let @baszalmstra chime in here. |
Adds a generic bounded/unbounded `Range` (taken from pubgrub, contributed there by me) struct which can be used to easily craft `VersionSet` implementations. I also moved files to the `internal` folder for types that should only be used inside the crate. --------- Co-authored-by: Tim de Jager <tim@prefix.dev>
IMO we add a I do like the |
Think that'll work well. I opened the other PR about a trait providing a |
this creates the module to define and parse the build number spec
Next PR will use the parsing and matching in
crate::match_spec