add retry behavior for package cache downloads #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2023
|
This looks very elegant. I am wondering if we want to stick that into a lower layer (e.g. in the We can also refactor that later to fix the immediate bug. |
wolfv
approved these changes
Aug 22, 2023
|
Bas explained that we can't stick it in a lower level because the streaming needs to be restarted as well. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retry behavior for extracting packages. I'm not entirely sure how I can test this properly though...
This was reported in pixi: prefix-dev/pixi#273 . I will try to test-drive it with pixi.