Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align with upcoming virtual package cep #1028

Merged

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Jan 15, 2025

This PR aligns our virtual package implementation with the upcoming virtual package cep. I think most of the changes proposed in the CEP make a lot of sense so I feel we can already merge this PR before the CEP is accepted.

In particular, I made the following changes:

  • __win now also reports the version of Windows.
  • __win can be overridden with CONDA_OVERRIDE_WIN
  • __linux can be overridden with CONDA_OVERRIDE_LINUX
  • __archspec can be overriden with CONDA_OVERRIDE_ARCHSPEC
  • __archspec falls back to deriving the archspec from the platform if it could not be determined.
  • __archspec is added as __archspec=1=0 if the no archspec could be determined for the current platform.

Changes I explicitly did not make (also left a question in the CEP):

  • osx-arm64 should fall back to arm64 archspec but we use m1 instead.
  • win-arm64 should fall back to arm64 archspec but we use aarch64 instead.

I left this in because arm64 is not an existing archspec and m1 and aarch64 are the base microarchitectures for osx-arm64 and win-arm64 respectively. I think this will yield better defaults.

I also added a VirtualPackages struct that contains all the virtual package implementations and provides handy utilities to convert it to a list of VirtualPackage or a list of GenericVirtualPackage. Detection of virtual packages is now also handled by this struct.

Tagging @jaimergp so he is aware of this!

@baszalmstra baszalmstra requested a review from wolfv January 15, 2025 21:44
@baszalmstra baszalmstra merged commit b17de29 into conda:main Jan 17, 2025
15 checks passed
@baszalmstra baszalmstra mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants