feat: Match GenericVirtualPackage with MatchSpec #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atchspec is virtual. This is useful to compare `depends` from a record to a `GenericVirtualPackage`
baszalmstra
approved these changes
Jan 7, 2025
baszalmstra
approved these changes
Jan 9, 2025
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working on improving
pixi's implementation of the virtual package requirements.I was reading the virtual packages from the
dependsfield of the package record, which could be parsed asMatchSpecs. So I implemented this. But to avoid the huge overhead of parsing all dependencies, I later reverted to doing thestarts_with("__")check again in pixi on the strings. I kept this feature inrattler_conda_types::MatchSpechowever, as it seems like a useful function.This PR also allows you to compare
MatchSpecswithGenericVirtualPackages, which I use to validate the system virtual packages with theMatchSpecsof a virtual dependency.I've also added some small convenience functions to make building the logic on the lockfile a little easier.