-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yes no parsing #664
Fix yes no parsing #664
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @marcoesters. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built an example MinicondaX using @marcoesters's dev branch, and the default [no]
now gets applied when I hit Enter, and the installer exits as expected.
I noticed two of the CI builds are failing on the example builds, but it's not clear what the causes are (here and here). Perhaps they just need a re-punch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this code appear so often in the installer makes me wonder whether we should put it in a function, but that can be done in a different PR.
Thanks!
Description
Improve yes/no parsing for interactive installation with sh installers.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?