Add text_errors option to build_outputs.licenses
#602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Jan 10, 2023
| If false, only the path will be included. | ||
| - `text_errors` (optional str, default=`None`): How to handle decoding errors when reading the |
There was a problem hiding this comment.
For a second I thought perhaps 'replace' would be a better default, but in the end it's probably safest to not mess with people's included licenses, and make them change a var to do it themselves, so +1 on None as the default as it is now
There was a problem hiding this comment.
Yea I thought about it too. Worst case people can use the path attribute and check / collect the licenses themselves.
larsoner
approved these changes
Jan 10, 2023
|
Thanks @jaimergp |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued work from #595
Some bundled license texts can be malformed, which leads to decoding errors. (see examples on Windows here). This allows users to specify how to handle that through the
open()errorsargument directly. Normally, you'd set this toreplace.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?