Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force use of nsis 3.01 on Windows #532

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

jaimergp
Copy link
Contributor

Temporary workaround for the CI issues we are seeing as part of #526

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 27, 2022
@jaimergp jaimergp merged commit ce2044f into conda:main Jul 27, 2022
@scottwsides
Copy link

Hi Jaime, I'm only asking this here because of your recent merge of the branding branch. A minor problem first... for a while I've been seeing

No local packages or working download links found for ruamel_yaml
error: Could not find suitable distribution for Requirement.parse('ruamel_yaml')

which normally just keeps going, but now no pkg file gets made, so I didnt know if this was something new. Also, since branding I see

Checking mac signature
pkgutil: option `--check-signature' requires an argument``

which was working in your branch. I'm building just by cloning source, going into my conda environment and doing

python setup.py install

Is this not the standard way? Thanks!

@jaimergp
Copy link
Contributor Author

To get the dev version I'd do something like this:

$ conda create -n constructor-dev constructor pip
$ conda activate constructor-dev
$ conda remove --force constructor
$ pip install https://github.com/conda/constructor/archive/main.tar.gz --no-deps

Try that and let me know if it works!

@scottwsides
Copy link

Thanks, I will try that. But I want to understand why building main doesnt work. Didnt you merge changes from osx-branding into main? I just want to be prepared for changes later (when I forget what has happened) and my installers might break.

@jaimergp
Copy link
Contributor Author

We don't use that option of pkgutil directly so no clue what might be wrong. If the issue persists please open an issue with more details about your installation and input files.

@scottwsides
Copy link

Sorry.... the pkgutil error is a red-herring. Thats in my script and is dying simply because constructor is failing. The pip install is fine... but I'm getting

phoenix:hpccloud-trunk swsides$ cs-env/bin/constructor --verbose chemistream-constructor
platform: osx-64
conda packages download: /Users/swsides/.conda/constructor/osx-64
Traceback (most recent call last):
File "cs-env/bin/constructor", line 8, in
sys.exit(main())
File "/Users/swsides/hpccloud-trunk/cs-env/lib/python3.8/site-packages/constructor/main.py", line 244, in main
main_build(dir_path, output_dir=out_dir, platform=args.platform,
File "/Users/swsides/hpccloud-trunk/cs-env/lib/python3.8/site-packages/constructor/main.py", line 112, in main_build
fcp_main(info, verbose=verbose, dry_run=dry_run, conda_exe=conda_exe)
File "/Users/swsides/hpccloud-trunk/cs-env/lib/python3.8/site-packages/constructor/fcp.py", line 398, in main
_urls, dists, approx_tarballs_size, approx_pkgs_size, has_conda = _main(
File "/Users/swsides/hpccloud-trunk/cs-env/lib/python3.8/site-packages/constructor/fcp.py", line 251, in _main
print("specs: %r" % specs)
TypeError: not all arguments converted during string formatting

Again... nothing else about my construct.yaml has changed that works with your osx-branding.

@jaimergp
Copy link
Contributor Author

That looks like your construct.yaml has some kind of issue in the specs field. Can you post the contents of that file here?

@scottwsides
Copy link

scottwsides commented Jul 27, 2022

Yes sure! Thanks for taking a look... oh I'm builfing on osx BTW


name: Chemistream
version: 0.60.0
company: Tech-X

license_file: ../eula.txt # [osx or linux]
license_file: ..\eula.txt # [win64]

ignore_duplicate_files: True
keep_pkgs: False
write_condarc: False
initialize_by_default: False

installer_type: exe # [win64]
post_install: post_install.bat # [win64]

Default windows path (NOTE: space after \ is a hack to get trailing '' correct

{% set installpath = "%USERPROFILE%" %} # [win64]
default_prefix_domain_user: "{{ installpath }}\chemistream\ " # [win64]

installer_type: sh # [linux]
post_install: post_install.sh # [linux]

installer_type: pkg # [osx]
post_install: post_install.sh # [osx]

notarization_identity_name: "Developer ID Application: Tech-X Corporation (55699AXW94)" # [osx]
signing_identity_name: "Developer ID Installer: Tech-X Corporation (55699AXW94)" # [osx]

------------------------------------------------------------------------------

Build channels

------------------------------------------------------------------------------

channels:

specs:

  • conda # Needed for installer to find env
  • launchpad # Launchpad GUI
  • makalii # Pure cloud management stuff

---------------------------------------------

Specific image commands for platform?

---------------------------------------------

welcome_image: cs_mac_header.png # [osx]
header_image: cs_mac_welcome.png # [osx]

welcome_image: cs_win_welcome.png # [win64]
header_image: cs_win_header.png # [win64]

icon_image: pkg_icon.png

@scottwsides
Copy link

So I switched back to your branch... and I'm still getting same errors. The first error is the ruamel_yaml 'Parse distribution' error. I dont think anything else in my build script has changed. So I cant build at all on mac now... which is kinda serious.

@jaimergp
Copy link
Contributor Author

Can you DM me on gitter? http://gitter.im/jaimergp

@scottwsides
Copy link

Sure... I'm on gitter now, I think. I havent used gitter before.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants