add initialize_conda and register_python keys to control whether to show these options
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Blocked by #505 |
|
Local tests:
|
|
Windows needs fixing. Looks like the y-axis accumulator is not working as expected.
|
|
Fixed locally! Screenshots of the different configs for With True / True (default):
With False / True:
With True / False:
With False / False:
|
initialize_conda and register_python keys to control whether to show these options (WIP)initialize_conda and register_python keys to control whether to show these options
larsoner
previously approved these changes
Jul 6, 2022
…to show these options (WIP)
e54fb5d to
5808ebe
Compare
jezdez
approved these changes
Aug 30, 2022
|
Amazing, thank you!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All installers will offer the user to initialize conda (all OS) and register Python as default (Windows only). Some applications might be using
condabehind the scenes but don't want to expose this to the user, so asking for that kind of options can be strange and surprising if they have never heard about conda before.This PR adds two keys to prevent this behavior:
initialize_conda(True by default). If false,conda initprompts won't appear onshinstallers. EXEs and PKGs won't show the checkboxes.register_python(True by default). If false, EXEs won't offer this option, which was discouraged anyway.