More issues with lief #5594
Comments
|
@h-vetinari sounds like we need to rebuild |
|
I have a PR upcoming |
|
Does it work against lief 0.15 though? It might be more an issue of missing osx ci coverage and #5565 being incomplete, https://lief.re/doc/stable/changelog.html#july-21th-2024 says "Re-scope |
From my observation, it still fails with 0.15 but works fine with 0.14. |
|
Thanks for looking into it. I think the code that fails might only be hit in an osx build? Either way, we need to add another or adjust the existing repodata patches, and I've got a proposed fix #5595 for the next conda-build release. |
|
Sorry if this is the wrong place to post, but I'm seeing issues with lief 0.15 on Linux: # >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
Traceback (most recent call last):
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda/exception_handler.py", line 18, in __call__
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda/cli/main.py", line 61, in main_subshell
exit_code = do_call(args, parser)
^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda/cli/conda_argparse.py", line 181, in do_call
result = plugin_subcommand.action(getattr(args, "_args", args))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/plugin.py", line 17, in build
return execute(args)
^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 622, in execute
api.build(
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/api.py", line 211, in build
return build_tree(
^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3656, in build_tree
packages_from_this = build(
^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 2767, in build
newly_built_packages = bundlers[pkg_type](
^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 1870, in bundle_conda
files = post_process_files(metadata, initial_files)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 1650, in post_process_files
post_build(m, new_files, build_python=python)
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/post.py", line 1764, in post_build
check_overlinking(m, files, host_prefix)
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/post.py", line 1589, in check_overlinking
return check_overlinking_impl(
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/post.py", line 1449, in check_overlinking_impl
all_needed_dsos, needed_dsos_for_file = _collect_needed_dsos(
^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/post.py", line 864, in _collect_needed_dsos
needed = get_linkages_memoized(
^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 1199, in __call__
value = self.func(*args, **kw)
^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 1228, in get_linkages_memoized
return get_linkages(
^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 635, in get_linkages
result_lief = inspect_linkages_lief(
^^^^^^^^^^^^^^^^^^^^^^
File "/home/duncan/opt/conda/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 486, in inspect_linkages_lief
if binary.type == lief.ELF.ELF_CLASS.CLASS64:
^^^^^^^^^^^^^^^^^^
AttributeError: module 'lief._lief.ELF' has no attribute 'ELF_CLASS'A simple test can reproduce: $ python3 -c "import lief; print(lief.ELF.ELF_CLASS)"
Traceback (most recent call last):
File "<string>", line 1, in <module>
AttributeError: module 'lief._lief.ELF' has no attribute 'ELF_CLASS'According to the release notes this is now $ python3 -c "import lief; print(lief.ELF.Header.CLASS)"
<class 'lief._lief.ELF.Header.CLASS'> |
|
Good find, I'll handle that too. What package build hit that, and why did it exercise a liefldd.py code path that none of the tests on CI did? |
This was a manual build of conda-forge/lal-feedstock@4c08ede. I am trying to reproduce in a PR for visibility, but the Linux builds aren't installing the latest conda-build (see conda-forge/lal-feedstock#107). The macOS builds are, and are falling over the bugs reported above. |
Checklist
What happened?
It seems lief 0.16 broke something else than #5564. logs from conda-forge/pyarrow-feedstock#144
Conda Info
Conda Config
Conda list
Additional Context
No response
The text was updated successfully, but these errors were encountered: