Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build to worker #945

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Oct 31, 2024

Building should only be done by workers. Other pieces of the application should not be accessing this module.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Previously, the coverage for build.py

conda_store_server/_internal/build.py         175     47    73%

Marginally increases

conda_store_server/_internal/worker/build.py      175     43    75%

Building should only be done by workers
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit bd50adc
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6723f9d279b783000856e9c0

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 471ceb7
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67253b38694bee0008f72e58

@soapy1 soapy1 requested a review from peytondmurray October 31, 2024 21:51
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the reorganization. I can see why this stuff wasn't tested before (it just sets values on Build items in the database in a pretty minimal way), but it's definitely good to have a more robust test suite here.

@soapy1 soapy1 force-pushed the move-build-to-worker branch from 539265a to ca1c9a0 Compare November 1, 2024 20:33
@soapy1 soapy1 merged commit 2daec59 into conda-incubator:main Nov 1, 2024
27 checks passed
@soapy1 soapy1 deleted the move-build-to-worker branch November 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants