Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move seeding tests functionality into test module #925

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Oct 25, 2024

partially addresses #914

Description

This PR moves a module that is used to seed the db for testing from inside the app module to the testing module. This also allows for the removal of the tests that test this seeding

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit eb0c5b6
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671c1ce136b5430008d2b392

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 34e2fae
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671c1cec6dc908000814d91a

@soapy1
Copy link
Contributor Author

soapy1 commented Oct 25, 2024

This seemed like a little bit of a strange pattern to me. I'm not sure if this is a common pattern in python apps, happy to close this PR if it is. Otherwise, cleaning it up while working through speeding up tests.

@peytondmurray
Copy link
Contributor

I certainly prefer this organization; these functions are exclusively used for building fixtures, which belong in conftest.py. I'm happy to merge this.

@peytondmurray peytondmurray merged commit 17f9d59 into conda-incubator:main Oct 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants