Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pin pyyaml dependency due to cython>=3 incompatibility #916

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[BUG] Pin pyyaml dependency due to cython>=3 incompatibility #916

merged 1 commit into from
Oct 24, 2024

Conversation

peytondmurray
Copy link
Contributor

Fixes #915.

Description

This pull request pins pyyaml==5.3.1 due to an incompatibility with cython>=3, which is a transitive dependency of this project.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1 Would you be willing to check that this works for you? It's enough to run tests and then hatch shell dev inside conda-store-server/.

@peytondmurray peytondmurray requested a review from soapy1 October 24, 2024 20:35
@peytondmurray peytondmurray marked this pull request as ready for review October 24, 2024 20:35
@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 677aa4d
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671aaf9d8825e00008249b32

soapy1
soapy1 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@soapy1 soapy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@soapy1 soapy1 merged commit b4c3981 into conda-incubator:main Oct 24, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soapy1 soapy1 soapy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Hatch dev environment broken due to cython>=3 and pyyaml>5.3.1 conflict
2 participants
@peytondmurray @soapy1