Add checkpointing and a "max packages to download" flag to CLI #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flow of conda-mirror is:
By checkpointing, I mean do steps 2, 3, 4 every N packages. In this case, I've hardcoded it to 25 (but that could easily be another configurable flag). The advantage of doing this is that it means that the mirror process can be interrupted pretty much at any point and you'll only lose, at most, 25 new packages that have been downloaded. As opposed to how this thing currently works where if the script is interrupted at any point then all of the packages will be deleted and you'll have to download them again.
I also added a
--max-packagesflag which can be useful for debugging