Add optional targets for reference.json and update.tar to conda-diff-tar #21
Conversation
…uring testing conda diff-tar
…lse blocks to prevent a crash on Windows where the logger is not inherited into the new process (Windows specific issue). In case logger is missing, print to stdout instead.
…llow package importers to change default globals.
…indpendent of operating system.
…infile/outfile functionality
|
Hi @FaustinCarter, I am not directly involved with this project, so I would need to ask other team members. @scopatz should we have some teams setup to ping "everyone" or at least the devs involved in a given project? Cheers! |
|
yes @goanpeca - we have maintenance teams for projects written into our governance - feel free to make then as you see fit! We should make a common name for them, something like |
|
Sounds good @beckermr , I started creating one a few days ago @conda-incubator/setup-miniconda-team 😆. Core and dev sounded more abstract and unfriendly than... team :-) |
|
Great! -team is perfect! |
|
I've added a |
|
Did not know about https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners that. Thanks @xhochy :-) |
|
We should put the mirror team in the code owners file and remove the people there to make life easier. |
👍 |
This PR adds a feature to diff_tar.py wherein the user can now specify
--infileand/or--outfilearguments to the conda-diff-tar script in order to specify where files should read/write from/to. Behavior is:--create, infile refers to the reference.json file, outfile refers to the update.tar file.--reference, infile is not accepted, outfile refers to the reference.json file.--show, infile refers to the references.json file, outfile is not accepted.This PR adds unit tests for the above.
This PR also adds Windows compatibility to all the tests. I tried to keep these fixes in their own commits for the most part to make cherry-picking easier if this is not a desired feature.
This PR closes #19 and also #17.
There is still a little work to do surrounding updating the changelog to reflect the new feature and potentially assigning a new minor version number. I'm not quite sure what the right format is, and was hoping to get some pointers from the maintainers for what changes would need to be added to merge this new feature in.