Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dry-run creates target directory #27

Closed
analog-cbarber opened this issue Jun 22, 2021 · 0 comments · Fixed by #64
Closed

--dry-run creates target directory #27

analog-cbarber opened this issue Jun 22, 2021 · 0 comments · Fixed by #64
Labels
bug Something isn't working

Comments

@analog-cbarber
Copy link

Not a big deal, but I was surprised to see that --dry-run will create the target directory if it does not already exist.

I usually expect --dry-run options to not modify the file system (except perhaps to create/remove temp files).
@xhochy xhochy added the bug Something isn't working label Jun 24, 2021
analog-cbarber added a commit to analog-garage/conda-mirror that referenced this issue Jul 15, 2021
@analog-cbarber
--dry-run no longer creates target dir (conda-incubator#27)
c7f9817
@xhochy xhochy mentioned this issue Feb 27, 2023
Merged
xhochy added a commit that referenced this issue Feb 27, 2023
@xhochy
Merge pull request #64 from conda-incubator/analog-garage/ag-misc
08899dd 
Fixes for issues #27, #31, #44, #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for issues #27, #31, #44, #47 conda-incubator/conda-mirror
2 participants
@xhochy @analog-cbarber