Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number to 16 to fix issue of pugixml 1.14 & 1.15 having same build number #369

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 18, 2025

Both #366 and #365 were merged using the build number 15, so now we have two different builds (one with pugixml==1.14.* and another with pugixml==1.15.*) with the same build number. This creates problems in the vtk metapackage, so for example we get error if we try to install:

traversaro@IITBMP014LW012:~$ micromamba create -n test24 vtk==9.3.1=qt_*_215 pugixml==1.15.*
conda-forge/linux-64                                        Using cache
conda-forge/noarch                                          Using cache

error    libmamba Could not solve for environment specs
    The following packages are incompatible
    ├─ pugixml =1.15 * is requested and can be installed;
    └─ vtk ==9.3.1 qt_*_215 is not installable because it requires
       └─ vtk-base [==9.3.1 qt_py310h01dc861_215|==9.3.1 qt_py311h75c0fa1_215|==9.3.1 qt_py312h04237f5_215|==9.3.1 qt_py313h245430a_215|==9.3.1 qt_py39h697e378_215], which requires
          └─ pugixml >=1.14,<1.15.0a0 *, which conflicts with any installable versions previously reported.
critical libmamba Could not solve for environment specs

while the same request with vtk-base works:

traversaro@IITBMP014LW012:~$ micromamba create -n test24 vtk-base==9.3.1=qt_*_215 pugixml==1.15.*

To avoid confusion on which version needs to be installed if one installs vtk 9.3.1, let's bump the base build number in the main version to 16.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 18, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13385796028. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

traversaro commented Feb 18, 2025

Windows builds are failing with error:

Preparing transaction: ...working... done
ERROR:conda.stderr:
Verifying transaction: ...working... done
ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::gl2ps-1.4.2-had7236b_1, conda-forge/win-64::libhwloc-2.11.2-default_ha69328c_1001
  path: 'library/readme.txt'



ERROR:conda.stderr:
ClobberWarning: Conda was asked to clobber an existing path.
  source path: D:\Miniforge\pkgs\libhwloc-2.11.2-default_ha69328c_1001\Library\README.txt
  target path: D:\bld\vtk_1739865634189\_test_env\Library\README.txt



Executing transaction: ...working... 
librsvg: The post-link script did not complete.
To take advantage of gdk-pixbuf's support for librsvg, please run:
    D:\bld\vtk_1739865634189\_test_env\Scripts\.gdk-pixbuf-post-link.bat

done
ERROR:conda.core.link:An error occurred while installing package 'conda-forge::gdk-pixbuf-2.42.12-hed59a49_0'.
Rolling back transaction: ...working... done
Traceback (most recent call last):
  File "D:\Miniforge\Scripts\conda-build-script.py", line 10, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\cli\main_build.py", line 622, in execute
    api.build(
  File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 211, in build
    return build_tree(
           ^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3671, in build_tree
    test(pkg, config=metadata.config.copy(), stats=stats)
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3423, in test
    environ.create_env(
  File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1047, in create_env
    _execute_actions(prefix, precs)
  File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1337, in _execute_actions
    unlink_link_transaction.execute()
  File "D:\Miniforge\Lib\site-packages\conda\core\link.py", line 348, in execute
    self._execute(
  File "D:\Miniforge\Lib\site-packages\conda\core\link.py", line 954, in _execute
    raise CondaMultiError(
conda.CondaMultiError: post-link script failed for package conda-forge::gdk-pixbuf-2.42.12-hed59a49_0
location of failed script: D:\bld\vtk_1739865634189\_test_env\Scripts\.gdk-pixbuf-post-link.bat
==> script messages <==
<None>
==> script output <==
stdout: 
stderr: 
return code: 3221225785

()

@traversaro
Copy link
Contributor Author

@conda-forge/vtk can you restart just the Windows builds? I am not sure if the error is transient, but I would prefer to avoid re-running all Linux jobs by restarting manually the CI by opening and closing the PR, thanks!

@Tobias-Fischer
Copy link
Contributor

Looks like an even earlier error now, same as before but when creating the host env (as opposed to test env in the previous attempt):

Executing transaction: ...working... 
librsvg: The post-link script did not complete.
To take advantage of gdk-pixbuf's support for librsvg, please run:
    D:\bld\vtk_1739906179393\_h_env\Scripts\.gdk-pixbuf-post-link.bat

done
ERROR:conda.core.link:An error occurred while installing package 'conda-forge::gdk-pixbuf-2.42.12-hed59a49_0'.
Rolling back transaction: ...working... done
Traceback (most recent call last):
  File "D:\Miniforge\Scripts\conda-build-script.py", line 10, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\cli\main_build.py", line 622, in execute
    api.build(
  File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 211, in build
    return build_tree(
           ^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3656, in build_tree
    packages_from_this = build(
                         ^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 2438, in build
    create_build_envs(top_level_pkg, notest)
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 2212, in create_build_envs
    environ.create_env(
  File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1047, in create_env
    _execute_actions(prefix, precs)
  File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1337, in _execute_actions
    unlink_link_transaction.execute()
  File "D:\Miniforge\Lib\site-packages\conda\core\link.py", line 348, in execute
    self._execute(
  File "D:\Miniforge\Lib\site-packages\conda\core\link.py", line 954, in _execute
    raise CondaMultiError(
conda.CondaMultiError: post-link script failed for package conda-forge::gdk-pixbuf-2.42.12-hed59a49_0
location of failed script: D:\bld\vtk_1739906179393\_h_env\Scripts\.gdk-pixbuf-post-link.bat
==> script messages <==
<None>
==> script output <==
stdout: 
stderr: 
return code: 3221225785

@traversaro
Copy link
Contributor Author

Related gdk-pixbuf issue: conda-forge/gdk-pixbuf-feedstock#48 .

@Tobias-Fischer Tobias-Fischer changed the title Bump build number to 16 Bump build number to 16 to fix issue of pugixml 1.14 & 1.15 having same build number Feb 19, 2025
@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Feb 19, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 20, 2025

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@traversaro
Copy link
Contributor Author

@conda-forge/vtk can you restart just the Windows builds? I am not sure if the error is transient, but I would prefer to avoid re-running all Linux jobs by restarting manually the CI by opening and closing the PR, thanks!

Now that the issue is fixed can we restart che windows ci again? Thanks!

@conda-forge-admin conda-forge-admin merged commit 2af1fe6 into conda-forge:main Feb 20, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants