Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #39

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6271827301, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dhirschfeld
Copy link
Member

(%PREFIX%) %SRC_DIR%>"%PREFIX%\python.exe" -s "%SRC_DIR%\run_test.py" 
import: 'trio'

(%PREFIX%) %SRC_DIR%>IF -1073740791 NEQ 0 exit /B 1 
Tests failed for trio-0.22.2-py312h2e8e312_1.conda - moving package to D:\bld\broken
WARNING:conda_build.build:Tests failed for trio-0.22.2-py312h2e8e312_1.conda - moving package to D:\bld\broken

@synapticarbors
Copy link
Member

It looks like there is still an open issue for python 3.12: python-trio/trio#2646

The CI error message is a bit opaque, and I haven't had time to dig into it.

@dhirschfeld
Copy link
Member

@conda-forge-admin, please rerender

@dhirschfeld
Copy link
Member

I haven't had time to dig into it.

I've published the artifacts which should let us reproduce... if you have a Windows box handy. I do, but just need to find the time to look into it!

@dhirschfeld
Copy link
Member

❯ python
Python 3.12.0rc3 | packaged by conda-forge | (main, Sep 19 2023, 13:41:36) [MSC v.1935 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import faulthandler
>>> faulthandler.enable()
>>> import trio
Windows fatal exception: access violation

Current thread 0x0000861c (most recent call first):
Windows fatal exception: access violation

NativeCommandExitException: Program "python.exe" ended with non-zero exit code: -1073740791.

@dhirschfeld
Copy link
Member

Python 3.12 installed with:

mamba create -c "conda-forge/label/python_rc" -n test312 python>=3.12.0a0

@richardsheridan
Copy link

This is likely a CFFI problem that we hit before: python-trio/trio#2714 (comment)

You might just double check if import cffi crashes in the test environment, and if so, there's nothing to do but wait for an upstream fix.

@dhirschfeld
Copy link
Member

You might just double check if import cffi crashes in the test environment, and if so, there's nothing to do but wait for an upstream fix.

Importing doesn't trigger the access violation but loading a DLL does:

(quantdev)
❯ python
Python 3.10.11 | packaged by conda-forge | (main, May 10 2023, 18:51:25) [MSC v.1934 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from cffi import FFI
>>> ffi = FFI()
>>> ffi.dlopen('ucrtbase')
<cffi.api._make_ffi_library.<locals>.FFILibrary object at 0x00000211AF4AC970>
>>> exit()

❯ mamba activate test312
(test312)
❯ python -X faulthandler
Python 3.12.0rc3 | packaged by conda-forge | (main, Sep 19 2023, 13:41:36) [MSC v.1935 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from cffi import FFI
>>> ffi = FFI()
>>> ffi.dlopen('ucrtbase')
Windows fatal exception: access violation

Current thread 0x00000e10 (most recent call first):
Windows fatal exception: access violation

NativeCommandExitException: Program "python.exe" ended with non-zero exit code: -1073740791.

@dhirschfeld
Copy link
Member

dhirschfeld commented Sep 26, 2023

@jakirkham
Copy link
Member

@conda-forge-admin, please restart CI

@jakirkham
Copy link
Member

Looks like CI is passing now 🙂

@synapticarbors synapticarbors merged commit 4869fc8 into conda-forge:main Oct 4, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python312-0-1_hecea7b branch October 4, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants