-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests into a separate package, plus rattler-build #107
Conversation
…onda-forge-pinning 2024.12.24.08.00.50
…onda-forge-pinning 2024.12.24.08.00.50
Eliminate the recipe conditions for cuda_major, since only CUDA 12+ is supported now. Replace the jinja `{% if %}` conditions with inline selectors, since the latter are more compatible with different tools (e.g. conda-recipe-manager).
After moving the tests out of the main package, its size reduces to 1.5M. The tests package itself is 9M. Proposed in issue conda-forge#22.
…onda-forge-pinning 2024.12.24.08.00.50
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12484953648. Examine the logs at this URL for more detail. |
Thanks I think reduced download sizes are definitely welcome! |
…onda-forge-pinning 2024.12.24.08.00.50
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12495694887. Examine the logs at this URL for more detail. |
I've added a rattler-build conversion, and filed output request in conda-forge/admin-requests#1248. FWICS conda-smithy crashes on it, I'm going to look into that later today. |
…onda-forge-pinning 2024.12.24.08.00.50
I'm going to guess that the osx failure is a fluke. |
The conda-smithy problems are conda-forge/conda-smithy#2165 and conda-forge/conda-smithy#2196. The former I've been able to workaround by avoiding nested conditions. |
I came to check in, and saw
failed due to connection issues. I always feel bad since conda-forge hammers webservers which are meant to be cached locally for data. Should we skip this test? |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
Yeah, FWICS |
I guess our cis clear cache unless you work really hard not to. So any access to the internet during testing should be discouraged |
I'm going to do a test run with pytest-socket to check for other cases of Internet access. |
Ok, so the failures are
|
Yeah. Any test that needs a download should be skipped google drive will definitely boot you…. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)